fix: Fix crash in Actor.push_data with PPE and a strict charging limit#664
Merged
fix: Fix crash in Actor.push_data with PPE and a strict charging limit#664
Actor.push_data with PPE and a strict charging limit#664Conversation
Contributor
janbuchar
commented
Nov 6, 2025
janbuchar
commented
- reported via Slack
janbuchar
added
adhoc
janbuchar
changed the title
Actor.push_data with PPE and a strict charging limit
Pijukatel
approved these changes
Nov 6, 2025
Contributor
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
It would be nice to add test for the combination of inputs that caused the bug.
Contributor
Author
the steps to reproduce it were basically to run an Actor with a spending limit that makes it impossible to charge even a single occurence of an event and then call |
janbuchar
added a commit
that referenced
this pull request
Nov 6, 2025
- follow up to #664 - I haven't managed to reproduce the actual bug with a test yet, so that will happen later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.